Mwalker [Fri, 25 Oct 2013 01:11:03 +0000 (01:11 +0000)]
Merge "@covers tags for unit tests"
Mwalker [Fri, 25 Oct 2013 01:09:58 +0000 (01:09 +0000)]
Merge "@covers tags for more test classes"
Mwalker [Fri, 25 Oct 2013 01:07:13 +0000 (01:07 +0000)]
Merge "@covers tags for the rest of test files.."
Mwalker [Fri, 25 Oct 2013 01:06:28 +0000 (01:06 +0000)]
Merge "add basic Status unit test"
jenkins-bot [Fri, 25 Oct 2013 00:15:28 +0000 (00:15 +0000)]
Merge "Triple default $wgMaxShellMemory (raise to 300 MB)"
umherirrender [Wed, 23 Oct 2013 18:36:52 +0000 (20:36 +0200)]
Pass language to File::getDescriptionText
Follow-Up: Ifcae821a51f4207e7816e710d3b3857c7ed438b6
Change-Id: I8e13f672fd37319add1c090a5b2f38c45d18fda5
Aaron Schulz [Thu, 24 Oct 2013 23:34:07 +0000 (16:34 -0700)]
Fixed broken quickDescribe() method
Change-Id: Ic68f483c4008ff6ae8c4accef2f9d1f180a5d377
Bartosz Dziewoński [Wed, 23 Oct 2013 20:56:50 +0000 (22:56 +0200)]
Triple default $wgMaxShellMemory (raise to 300 MB)
100 MB is no longer sufficient.
That value was chosen back in 2006 (r14795); the world has largely
moved on to 64-bit programs since then, and applications such as
ImageMagick seem to use 16-bit precision for each image channel.
It's not enough to scale regular large-ish images on default system
settings anymore.
Bug: 34241
Change-Id: I66bbe12925689f9273f3b5fb29adc8c15c828c70
addshore [Thu, 24 Oct 2013 22:11:15 +0000 (23:11 +0100)]
add basic Status unit test
Adds unit tests for some of the more basic
parts of the Status class
has todos at the bottom of the file for all other
methods that need to be tested
Change-Id: Ic2f2abafb44ef86af207c7595e440672dfcf4f1e
jenkins-bot [Thu, 24 Oct 2013 21:36:16 +0000 (21:36 +0000)]
Merge "mediawiki.inspect: Support IE8's style.sheet.rules property"
jenkins-bot [Thu, 24 Oct 2013 21:04:36 +0000 (21:04 +0000)]
Merge "Set $parentLen in contributions"
Translation updater bot [Thu, 24 Oct 2013 20:58:02 +0000 (20:58 +0000)]
Merge "Localisation updates from translatewiki.net."
Translation updater bot [Thu, 24 Oct 2013 20:56:36 +0000 (20:56 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I7d7dfd1a1e1a395c639b30489bacceedfbfc6330
jenkins-bot [Thu, 24 Oct 2013 20:54:57 +0000 (20:54 +0000)]
Merge "Fix undefined variable in Status::getMessage()"
Bartosz Dziewoński [Thu, 24 Oct 2013 20:25:10 +0000 (22:25 +0200)]
Set $parentLen in contributions
Follow-up to I77dd45eb.
Bug: 56115
Change-Id: I17bd160577e6b287cc5a61e2a3b983b035c87f81
addshore [Thu, 24 Oct 2013 20:30:43 +0000 (21:30 +0100)]
@covers tags for the rest of test files..
Change-Id: I0fafe80531325a412472ab7c9fc6d81c861b3751
Bartosz Dziewoński [Thu, 24 Oct 2013 19:31:49 +0000 (21:31 +0200)]
mediawiki.inspect: Support IE8's style.sheet.rules property
Standards-compliant browsers use 'cssRules', IE8 uses 'rules',
some browsers (e.g. Chrome) support both.
Bug: 56107
Change-Id: Ief0b5e38c8ff29efea510bf3725127c2bbfccd59
addshore [Thu, 24 Oct 2013 19:35:04 +0000 (20:35 +0100)]
@covers tags for more test classes
Change-Id: I19d49c279646a4b4c595700e53b790ba4eb9521e
aude [Thu, 24 Oct 2013 19:17:39 +0000 (19:17 +0000)]
Fix undefined variable in Status::getMessage()
If $shortContext and $longContext are false, and there
are errors, then $s is undefined.
Change-Id: Ie07f80b43a48a6fc4ed28b2c519f51fd32690bc8
jenkins-bot [Thu, 24 Oct 2013 19:22:32 +0000 (19:22 +0000)]
Merge "Make TOC hideable"
Kunal Mehta [Thu, 17 Oct 2013 06:48:48 +0000 (23:48 -0700)]
Merge SimpleAntiSpam extension into core
Adds an empty, hidden input field to the edit interface, and will
reject any edit if that field is filled in. This will protect
against the simplest form of spambots.
Localized messages will be imported separately.
Bug: 52063
Change-Id: I185b6a1e232299f496244a23f4bf0dc6ea22b6c9
jenkins-bot [Thu, 24 Oct 2013 18:29:35 +0000 (18:29 +0000)]
Merge "Cleanup Api phpunit Tests"
jenkins-bot [Thu, 24 Oct 2013 18:27:03 +0000 (18:27 +0000)]
Merge "Add more ApiFormat format tests"
jenkins-bot [Thu, 24 Oct 2013 18:19:52 +0000 (18:19 +0000)]
Merge "@covers tags for maintenance tests"
Mwalker [Thu, 24 Oct 2013 18:17:06 +0000 (18:17 +0000)]
Merge "@covers tags for the rest of /media/* tests"
addshore [Wed, 23 Oct 2013 16:01:33 +0000 (17:01 +0100)]
Cleanup Api phpunit Tests
- Splits multiple classes into individual files
- Adds @covers tags
- Fixes scope
Change-Id: I7d2816d3574fa53a2aaa8e2a84b7a7ecdd245252
addshore [Thu, 24 Oct 2013 18:12:22 +0000 (19:12 +0100)]
@covers tags for maintenance tests
Change-Id: Ica5f351f71ee5fccae97560f2de6d75fc5da721b
addshore [Wed, 23 Oct 2013 15:10:02 +0000 (16:10 +0100)]
Add more ApiFormat format tests
Adds tests for Json and wddx formats
Add @covers tags
Fixes some comments
Fixes scope
Change-Id: I5f22097ddcaeb917f856ba7aa0cb793caa17925e
addshore [Thu, 24 Oct 2013 18:04:38 +0000 (19:04 +0100)]
@covers tags for the rest of /media/* tests
Change-Id: I12879baf7810648d3ec0789feac5af364d5696f7
Mwalker [Thu, 24 Oct 2013 18:01:24 +0000 (18:01 +0000)]
Merge "@covers for ApiQuery stuff"
Mwalker [Thu, 24 Oct 2013 17:56:35 +0000 (17:56 +0000)]
Merge "@covers tags for inclues/*Test"
addshore [Thu, 24 Oct 2013 16:45:52 +0000 (17:45 +0100)]
@covers tags for unit tests
Change-Id: I2b486b38326bf23bd379efba2142034e24c0745f
Reedy [Thu, 24 Oct 2013 17:13:19 +0000 (18:13 +0100)]
Initial bump to 1.23
Change-Id: I1c2d7bdd1d861ace3f7e7bd8f8f0047c31194446
addshore [Thu, 24 Oct 2013 10:54:02 +0000 (11:54 +0100)]
@covers tags for inclues/*Test
Change-Id: Id28acdd8fe0028bf1e46344cfed131076c8f4c95
Tyler Anthony Romeo [Sun, 30 Jun 2013 20:45:45 +0000 (22:45 +0200)]
Fix double-parsing of account creation messages.
Account creation messages don't need to be parsed. This is
a temporary fix to follow up when double-parsing was accidentally
added in
69ea4400037 (I402c6bebcfe).
Bug: 44718
Bug: 52191
Change-Id: I333d5468820994625348316ebf6c57d4df025284
addshore [Tue, 22 Oct 2013 10:58:24 +0000 (12:58 +0200)]
Cleanup skins/SiteBarTest and @todo/covers
Change-Id: I501d04ddbeee23539337b68142ee6c1371a63d98
addshore [Thu, 24 Oct 2013 10:04:00 +0000 (11:04 +0100)]
@covers for ApiQuery stuff
Change-Id: Id8a89abd545d8e2a95b1d246776049b9c888e53c
addshore [Thu, 24 Oct 2013 09:53:24 +0000 (10:53 +0100)]
@covers for all GlobalFunc tests
Also split 2 tests off into their correct test classes,
this methods are clearly no longer global functions
Change-Id: I482433f3099e72507a766e85d9576ff36e58b9ad
Brad Jorsch [Tue, 27 Aug 2013 19:28:52 +0000 (15:28 -0400)]
Improve linkprefix regular expressions
The regular expression in the linkprefix message is run against the
entire page up to each wikilink, and is expected to capture one group
having everything except the prefix and another having only the prefix.
For long pages this winds up being a lot of text, so inefficient regular
expressions are going to cause problems.
The current regex is this:
/^(.*?)([a-zA-Z\\x80-\\xff]+)$/sD
This is not efficient: it will scan through the string trying to match
against every run of one or more letters/non-ASCII characters,
backtracking at every one except possibly the last. The only reason this
hasn't been a huge problem everywhere is because only a few languages
have this feature enabled.
This change replaces this with this regex:
/^((?>.*(?<![a-zA-Z\\x80-\\xff])))(.+)$/sD
This is rather more efficient: it will grab the whole string (which is
actually fast even for huge strings), then back off character by
character until it finds one that isn't a letter/non-ASCII.
Note that the above could be simplified somewhat:
/^((?>.*[^a-zA-Z\\x80-\\xff]|))(.+)$/sD
The performance improvement here is minor, and Gujarati, Church Slavic,
Udmurt, and Ukrainian would still need the other style for their current
implementations.
For Gujarati, we also use another regex trick: a look-behind assertion
in PCRE must be fixed length, so something like (?<!a|bb) won't work.
But that regex fragment is equivalent to (?<!a)(?<!bb) which is allowed,
so we use that instead.
Bug: 52865
Change-Id: Iaa7eaa446b3f045a9ce970affcb2a889f44bdefd
addshore [Wed, 23 Oct 2013 22:51:31 +0000 (23:51 +0100)]
Fix scope on all /phpunit test methods
Change-Id: I3ce92463d485a0fb23e464e9a8059330f32d79af
addshore [Wed, 23 Oct 2013 22:12:39 +0000 (23:12 +0100)]
Cleanup tests/includes/media
- Adds @covers tags
- fixes comments
- fixes scope
- adds @todos
- split files per class
Change-Id: Id5aaa20769725a96f22fb838d376697c250874a5
jenkins-bot [Thu, 24 Oct 2013 00:53:48 +0000 (00:53 +0000)]
Merge "mediawiki.inspect: use $.toJSON & add workaround for FF oddity"
Ori Livneh [Thu, 24 Oct 2013 00:37:21 +0000 (17:37 -0700)]
mediawiki.inspect: use $.toJSON & add workaround for FF oddity
* Use $.toJSON rather than JSON.stringify. Make mediawiki.inspect depend on
jquery.json.
* Firefox doesn't define a console.table, but doesn't throw an exception either
if you attempt to invoke it. Use Function.prototype#call to call Firefox's
bluff.
Change-Id: Ib45487d10488f08a98d9635ab9a2a9212e9ef69f
jenkins-bot [Wed, 23 Oct 2013 23:44:42 +0000 (23:44 +0000)]
Merge "New hook accommodates non-revision rc queries"
Erik Bernhardson [Tue, 15 Oct 2013 22:21:34 +0000 (15:21 -0700)]
New hook accommodates non-revision rc queries
Within Special:RecentChanges the default non-extended query contains
( rc_this_oldid=page_latest OR rc_type=3 )
Wikidata has previously used the SpecialWatchlistQuery hook to look for
this exact string and change rc_type=3 to rc_type IN (3,5). Flow is another
type of change that doesn't have a matching row in revisions to match
page_latest for and needs to be added to this query.
This patch adds a new hook, SpecialWatchlistGetNonRevisionTypes, which allows
different extensions to add to a list of values for rc_type (or rc_source once
85787 is merged). This will allow multiple extensions to affect the resulting
query without them breaking eachother.
Change-Id: Id6916fe999c0faa38de878b7b5687e7ea00901bd
Brad Jorsch [Fri, 18 Oct 2013 14:54:58 +0000 (10:54 -0400)]
Add $wgSemiprotectedRestrictionLevels
It's possible that a wiki could introduce new protection levels that
should be considered "semiprotected". For example, if an
"emailconfirmed" protection level were added and an appropriate entry
were made in $wgAutopromote, that might be considered semi-protection
since anyone can automatically gain the ability to edit those pages
merely by setting and confirming their email address.
The most straightforward way to take care of this is to add a config
variable to specify which protection levels are considered
"semiprotected". So let's do that.
Also, let's take the opportunity to make
$title->isSemiProtected( 'create' ) works correctly.
Bug: 43462
Change-Id: Ic9db6ff6cbd84bd9734be09efbea5a5891197fa0
Translation updater bot [Wed, 23 Oct 2013 18:58:35 +0000 (18:58 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I0073d11e39dd5a11d7c8c44b80401ad7b8fd6313
jenkins-bot [Wed, 23 Oct 2013 18:46:02 +0000 (18:46 +0000)]
Merge "mediawiki.util: Use 'wikipage.content' hook for TOC hiding"
jenkins-bot [Wed, 23 Oct 2013 18:16:48 +0000 (18:16 +0000)]
Merge "Remove all instances of the word "iff""
Tim Starling [Tue, 11 Jun 2013 23:01:52 +0000 (09:01 +1000)]
Remove all instances of the word "iff"
It's elitist mathematical jargon. In all cases dealt with here, it adds
no additional meaning compared to "if", beyond what was already obvious
from context. Thus, its only purpose is to smugly demonstrate that the
author attended their second-year mathematics classes, at the expense of
causing confusion for everyone who doesn't have such a background.
If you really think you need to convey extra information beyond what
"if" gives you, the English language contains plenty of devices for doing
so, without resorting to neologisms.
Change-Id: Iae21095d02ec2935c10e94f532235c2671c115b1
jenkins-bot [Wed, 23 Oct 2013 17:01:14 +0000 (17:01 +0000)]
Merge "Fix doc error in new incr test"
Matthew Flaschen [Wed, 23 Oct 2013 16:53:00 +0000 (12:53 -0400)]
Fix doc error in new incr test
It covers all implementations of the abstract class method BagOStuff::incr.
Change-Id: I763985477b8564857a0905019c4485dd36f84539
jenkins-bot [Wed, 23 Oct 2013 15:54:16 +0000 (15:54 +0000)]
Merge "tablesorter: Unbreak abbreviated month name support"
Siebrand Mazeland [Wed, 23 Oct 2013 12:16:03 +0000 (14:16 +0200)]
Address PHP CodeSniffer errors and warnings
One class of errors left unaddressed: Class name "WebInstaller_Language"
is not in camel caps format. I think this can be changed, too, but I
wasn't able to quickly find out where class names are being created.
Change-Id: I920b0231db1b70b68c6c8907257c288a0e112668
addshore [Tue, 22 Oct 2013 23:50:38 +0000 (00:50 +0100)]
General cleanup of Parser tests
- Fixes scope
- Adds covers tags
Change-Id: I6024f2f7cc7a1812a417c6c389b0a15addde0b5e
Bartosz Dziewoński [Wed, 23 Oct 2013 09:59:40 +0000 (11:59 +0200)]
tablesorter: Unbreak abbreviated month name support
Regression from If758499f. Trailing dot was being removed
for genitive forms instead of abbreviated forms.
Bug: 56038
Change-Id: I353da785ff4a1203ae54a981c3c946f9df452902
addshore [Tue, 22 Oct 2013 09:46:48 +0000 (11:46 +0200)]
Cleanup MagicVariableTest
- Give methods scope
- Make providers static
- Add @covers todo
- Merge the Providers file that is only used in here
Change-Id: I60a6bbd5a8ad3d9d414de493ec2b083f52114a7b
jenkins-bot [Wed, 23 Oct 2013 07:11:21 +0000 (07:11 +0000)]
Merge "mw.api.postWithToken now forwards promise on fail if we have token"
Kevin Israel [Tue, 15 Oct 2013 13:42:48 +0000 (09:42 -0400)]
Parser::replaceInternalLinks: fix batching
The parser unnecessarily made individual checks for existence of
pages that were neither in LinkCache nor linked only with a fragment.
A Title::isKnown() call in Parser::replaceInternalLinks2() (added in
bca8b8ad7d2f) caused this.
Title::isKnown() was used to avoid treating a link to a distinct page
as a self-link even when the title happened to match one of the variants
returned by Language::autoConvertToAllVariants(). This change fixes
the bug by moving the problematic portion of the self-link check into
LinkHolderArray::doVariants().
Change-Id: I586e11e8b47308980ea04087ebc4246c397a8f53
Brad Jorsch [Fri, 18 Oct 2013 14:29:36 +0000 (10:29 -0400)]
Use restriction-level-* messages in Linker::formatTemplates
The current implementation of Linker::formatTemplates only checks for
"sysop" and "autoconfirmed", and completely ignores any other protection
levels. That needs fixing.
Rather than introducing additional messages "template-protected-*" to
match template-protected and template-semiprotected, let's just use the
existing restriction-level-foo messages and wrap them in parentheses.
The old messages are kept for backwards compatability, but could
probably be considered deprecated.
Bug: 43462
Change-Id: I0c507f4ecc1921f599acbda834fa55e96388fa7b
Tim Starling [Fri, 7 Jun 2013 00:31:37 +0000 (10:31 +1000)]
Avoid master queries in Revision::newFromTitle(..., Revision::READ_NORMAL)
The fallback to master makes sense in Revision::newFromId(), since a
revision ID known to exist by some other means might be present in the
master but not in the slave. But it doesn't make sense for
Revision::newFromTitle(), where by far the most common cause of this
case being hit is the page being nonexistent.
Change-Id: I41189fcde1b8065ac134982241376d63b78732a1
jenkins-bot [Tue, 22 Oct 2013 23:49:01 +0000 (23:49 +0000)]
Merge "Fix Redis increment behavior by using BagOStuff->incr instead"
jenkins-bot [Tue, 22 Oct 2013 23:47:25 +0000 (23:47 +0000)]
Merge "Test BagOStuff->incr method"
Matthew Flaschen [Tue, 22 Oct 2013 21:35:23 +0000 (17:35 -0400)]
Fix Redis increment behavior by using BagOStuff->incr instead
Due to the PHP serialization, the Redis native INCR and INCRBY do not
work. This instead falls back on the parent class's incr, which uses
lock and unlock, and incrementing on the PHP side.
Bug: 55986
Change-Id: I500199aeb935963ca118fde163bd7ba0cba8f79f
Matthew Flaschen [Tue, 22 Oct 2013 05:55:25 +0000 (01:55 -0400)]
Test BagOStuff->incr method
Change-Id: I3b72f19df82ee302dee47dcf22b69ed9bb6ff8e0
Fomafix [Sun, 22 Sep 2013 14:15:20 +0000 (16:15 +0200)]
mediawiki.util: Use 'wikipage.content' hook for TOC hiding
Bug: 54437
Change-Id: I82f441111bf3d6018b569dc728a3c152b721db7d
Aaron Schulz [Sun, 16 Jun 2013 20:48:17 +0000 (13:48 -0700)]
lockmanager: QuorumLockManager subclasses can get EX/SH locks at once
* Also reduced rount trips in doUnlockingRequestBucket().
* Also removed some redundant doc comments.
Change-Id: I81878e92332509bd7fda9ddeef950b774f5b015d
addshore [Tue, 22 Oct 2013 10:32:29 +0000 (12:32 +0200)]
Cleanup /languages/* tests
This change:
- Adds method scope
- adds @covers tags
- adds various @todos
- fixes some comments
Before the changes tests ran with:
1383 tests, 1412 assertions 10 skips
After changes the results remain the same
Change-Id: Iee57447bdb47026952ef5dcce6fed5dad0f80e52
Niklas Laxström [Tue, 22 Oct 2013 09:50:05 +0000 (09:50 +0000)]
mw.api.postWithToken now forwards promise on fail if we have token
Without this fix the callers of this function could not read the
failure code and result, because we returned undefined. Because
we are using a filter function, we need to explicitly return the
promise to pass it forward.
Change-Id: I71984ac827618459f723b0b9f47d4dc29e2a2f70
addshore [Mon, 21 Oct 2013 21:09:13 +0000 (23:09 +0200)]
Add more @covers tags and test cleanup
Other cleanup includes
- Adding method scopes
- Fixing php comments
- Adding todos
Change-Id: I0a231008e6a59110ffcab6af1bd8c4d3ee13f21d
Mwalker [Tue, 22 Oct 2013 02:34:45 +0000 (02:34 +0000)]
Merge "Mention the new HTMLForm 'vform' display format."
jenkins-bot [Tue, 22 Oct 2013 02:34:27 +0000 (02:34 +0000)]
Merge "Fixes for duplicateStderr (I833aeb3a)"
S Page [Tue, 22 Oct 2013 02:26:08 +0000 (19:26 -0700)]
Mention the new HTMLForm 'vform' display format.
Change Id03d185bbee990595bfc469a61163cc598fc3441 added the feature.
Change-Id: I17ccb127e47047dc32f930ce1775496ea22410d2
Translation updater bot [Mon, 21 Oct 2013 22:51:33 +0000 (22:51 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I0539a27c72b9a270db4e3b29a4c357e40d806353
jenkins-bot [Mon, 21 Oct 2013 20:35:36 +0000 (20:35 +0000)]
Merge "mediawiki.inspect: add CSS report"
jenkins-bot [Mon, 21 Oct 2013 20:28:44 +0000 (20:28 +0000)]
Merge "Added a few more trx sanity checks to DatabaseBase"
jenkins-bot [Mon, 21 Oct 2013 20:24:22 +0000 (20:24 +0000)]
Merge "Have list items occupy their own line"
Translation updater bot [Mon, 21 Oct 2013 19:42:49 +0000 (19:42 +0000)]
Localisation updates from translatewiki.net.
Change-Id: I922e660fafc7a952129beebeaed001712f5c2bc1
jenkins-bot [Mon, 21 Oct 2013 17:45:26 +0000 (17:45 +0000)]
Merge "Clean up old title on move before reset article id"
jenkins-bot [Mon, 21 Oct 2013 17:43:37 +0000 (17:43 +0000)]
Merge "jquery.localize: Fix incorrect use of void tag for <html:msg>"
jenkins-bot [Mon, 21 Oct 2013 17:39:13 +0000 (17:39 +0000)]
Merge "Fix typo erronously -> erroneously"
jenkins-bot [Mon, 21 Oct 2013 17:37:36 +0000 (17:37 +0000)]
Merge "Add 'RedisPubSubFeedEngine' feed engine"
Timo Tijhof [Mon, 21 Oct 2013 17:29:16 +0000 (19:29 +0200)]
Fix typo erronously -> erroneously
Follows-up
1aed5382d2.
Change-Id: I1e0cbc3dfa529816446c3aec6372eb2b821ee540
Timo Tijhof [Mon, 21 Oct 2013 17:26:44 +0000 (19:26 +0200)]
jquery.localize: Fix incorrect use of void tag for <html:msg>
Follows-up
55dac1f which errounously changed a few <html:msg />
to <html:msg> while trying to fix up <span/></span>.
Bug: 40598
Change-Id: I987fa288cc1b97a8a5fb367aae2626d7d0b48238
Ori Livneh [Mon, 26 Aug 2013 06:46:21 +0000 (23:46 -0700)]
Add 'RedisPubSubFeedEngine' feed engine
This patch adds a class which implements the RCFeedEngine interface by
publishing recent change notifications to Redis. The class handles the
'redis://' URI scheme. Recent changes are PUBLISHed to the channel 'rc'; a
different channel name may be specified as a path component.
Change-Id: I846036c091c45059a8947245a1efe92c9800dcf4
Aaron Schulz [Mon, 21 Oct 2013 17:20:34 +0000 (10:20 -0700)]
Added ceph comment
Change-Id: Ice9efd7ada10e1896afd0185a6305f6852e9605d
Aaron Schulz [Mon, 19 Aug 2013 19:26:01 +0000 (12:26 -0700)]
Added a few more trx sanity checks to DatabaseBase
* Also track the caller that added the callbacks
Change-Id: Idc4d9e4a89fcee28bd4b18ad6d8c6b09b9fe7e75
Siebrand Mazeland [Fri, 4 Oct 2013 05:54:44 +0000 (07:54 +0200)]
Declare visibility on class properties
As pointed out by phpcs:
The var keyword must not be used to declare a property
(PSR2.Classes.PropertyDeclaration.VarUsed)
Set to public, as this is also done for class properties in classes these
ones extend.
Also break some long lines to silence CodeSniffer.
Change-Id: I77dd45eb2bf1d405d429603b97d5cbfb7ea04ad0
addshore [Mon, 21 Oct 2013 08:46:11 +0000 (10:46 +0200)]
Add @covers tags for more tests
Change-Id: Iff3af78e9b41c445b7f066b6c0d0f4a87d2d6c4e
Tim Starling [Mon, 21 Oct 2013 04:18:04 +0000 (15:18 +1100)]
Fixes for duplicateStderr (I833aeb3a)
* Separate code from data. $2 in limit.sh is an option list.
* Don't duplicate stderr on linux when limit.sh is not used, unless
duplicateStderr is specified
Change-Id: I8e6e74810864830c12af627bfbe75e74ba34e3e3
jenkins-bot [Mon, 21 Oct 2013 01:24:27 +0000 (01:24 +0000)]
Merge "Simplify boolean attribute handling for Html::input in templates"
jenkins-bot [Mon, 21 Oct 2013 01:19:27 +0000 (01:19 +0000)]
Merge "Make it possible for EditPage::getCopyrightWarning to return HTML"
jenkins-bot [Mon, 21 Oct 2013 01:17:52 +0000 (01:17 +0000)]
Merge "Remove proxy check in EditPage.php"
Kevin Israel [Mon, 30 Sep 2013 00:26:15 +0000 (20:26 -0400)]
Remove proxy check in EditPage.php
$wgBlockOpenProxies, $wgProxyPorts, $wgProxyScriptPath, and
$wgProxyMemcExpiry have been removed, along with the open proxy
scanner script they were added for.
Bug: 54597
Change-Id: Id4c7521443f04995df3d8762d23629c18ada76f8
jenkins-bot [Mon, 21 Oct 2013 00:54:56 +0000 (00:54 +0000)]
Merge "Remove 'Debug' hook from wfDebug and wfDebugLog"
Ori Livneh [Sun, 20 Oct 2013 08:09:53 +0000 (01:09 -0700)]
mediawiki.inspect: add CSS report
This patch extends mediawiki#inspect to add a notion of 'reports'. Instead of
there being one single view for all ResourceLoader module debug data, you can
now request that a specific report be run. Each report highlights a set of
metrics that are unified by some common theme.
The previous, unqualified report is now branded the 'size' report. In addition
to it, this patch also adds a CSS report, which prints the count of selectors
and the count of selectors that match against the current time
Change-Id: I0e7a47b5a93a66ecb103fe30a3de8a2ca8a4eb84
Bartosz Dziewoński [Fri, 18 Oct 2013 20:34:31 +0000 (22:34 +0200)]
BaseTemplate: Exclude two more attributes in makeLink()
'context' and 'primary' are used internally by some SkinTemplate
functions and Vector. They should not be passed on to HTML.
Bug: 55659
Bug: 55660
Change-Id: I1f7a656aacc93f9bf289c481f258824ae28ccf4e
Translation updater bot [Sun, 20 Oct 2013 21:52:43 +0000 (21:52 +0000)]
Merge "Localisation updates from translatewiki.net."
jenkins-bot [Sun, 20 Oct 2013 20:59:15 +0000 (20:59 +0000)]
Merge "Don't match HTML entities in language conversion syntax"
Bartosz Dziewoński [Wed, 16 Oct 2013 16:57:12 +0000 (18:57 +0200)]
Simplify boolean attribute handling for Html::input in templates
The Html class supports this handy shorthand.
Change-Id: Ie34790fa650c7ecad02c2d91130bf0db9172ea3f